-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28686 MapReduceBackupCopyJob should support custom DistCp options #6017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rmdmattingly
force-pushed
the
HBASE-28686
branch
from
June 21, 2024 18:19
8847a2c
to
b169030
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rmdmattingly
force-pushed
the
HBASE-28686
branch
from
June 21, 2024 19:52
b169030
to
ab064a4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I believe these build failures are just noise, and will be fixed by a change that I've added to another PR: #6018 (comment) |
Apache9
reviewed
Jul 3, 2024
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rmdmattingly
force-pushed
the
HBASE-28686
branch
from
July 10, 2024 19:43
83e9cc6
to
bee79dc
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Jul 11, 2024
ndimiduk
approved these changes
Jul 18, 2024
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 18, 2024
…ns (apache#6017) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 18, 2024
…ns (apache#6017) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 18, 2024
…ns (apache#6017) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ns (#6017) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
rmdmattingly
added a commit
to HubSpot/hbase
that referenced
this pull request
Jul 19, 2024
…ns (apache#6017) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk
pushed a commit
that referenced
this pull request
Jul 22, 2024
…ns (#6017) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 22, 2024
…ns (apache#6017) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk
pushed a commit
that referenced
this pull request
Jul 22, 2024
…ns (#6017) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The MapReduceBackupCopyJob class provides no means for updating DistCp job options. This means that you're stuck with defaults, which isn't always desirable. For example, my workplace would like the freedom to deviate from at least two DistCp defaults:
distcp.direct.write
— we would like to set this to true, because writing and renaming tmp files is expensive in S3 (where we store our backups).we would also like control over the number of mappers that DistCp will run
Proposed Solution
It is not the prettiest solution, but I'm proposing that we support DistCp customizations via the given backup client configuration like this. It's necessary to do this conf -> arg conversion because we still want to use DistCp's run method, which expects args, so as to not change any error codes. Hadoop actually does something similar, but in the opposite direction — the DistCp job has logic to convert the args back to configurations (lol).
Further, the DistCp API is really unfortunately designed for programmatic use, so it doesn't leave us great alternatives. For example, it doesn't matter what you pass in as DistCpOptions to the constructor if you use the run method, your options will be overwritten based on the args that you pass in. Alternatively, if you pass in the DistCpOptions in the constructor and use DistCp#execute or DistCp#createAndSubmitJob, then you get none of the error specificity!
@ndimiduk @charlesconnell @hgromer